feat(backend): Expose and use min_confirmations filter to get utxos #2601
+34
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bitdivine please review |
lmuntaner
force-pushed
the
lm-expose-min-confirmations-utxos
branch
from
fddc93b
to
6acbb54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The bitcoin API to get utxos exposes a filter for the mininum confirmations of the transaction.
In this PR, I expose this filter in
get_all_utxosand use it in thebtc_select_user_utxos_feeendpoint.Changes
get_all_utxos.get_utxos.get_all_utxoswith 6 minimum confirmations.Tests
We can't add integration tests for bitcoin api until pocket-ic supports bitcoin.